build(deps): bump org.scala-lang:scala-library from 2.12.20 to 2.12.21#732
build(deps): bump org.scala-lang:scala-library from 2.12.20 to 2.12.21#732dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
bestbeforetoday
left a comment
There was a problem hiding this comment.
In addition to updating uses of Scala 2.12, this PR incorrectly changes uses of Scala 2.13 to 2.12.
Bumps [org.scala-lang:scala-library](https://github.com/scala/scala) from 2.12.20 to 2.12.21. - [Release notes](https://github.com/scala/scala/releases) - [Commits](scala/scala@v2.12.20...v2.12.21) --- updated-dependencies: - dependency-name: org.scala-lang:scala-library dependency-version: 2.12.21 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
290d0c0 to
f560e06
Compare
bvolpato
left a comment
There was a problem hiding this comment.
The reviewer (@bestbeforetoday) correctly identified that this PR incorrectly changes uses of Scala 2.13 to 2.12. This is a Dependabot bug — it matched both scala-2-12 and scala-2-13 version lines and replaced both with 2.12.21.
Recommendation: Close this PR. If the Scala 2.12 bump is desired, a manual PR that only updates the scala-2-12 version line would be the correct approach.
|
Closing as suggested by @bvolpato. Dependabot is obviously not going to fix this PR and it cannot be merged as-is so little point in keeping it open. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps org.scala-lang:scala-library from 2.12.20 to 2.12.21.
Release notes
Sourced from org.scala-lang:scala-library's releases.
Commits
b7cc68aMerge pull request #11186 from lrytz/revert-ordering1ddafacRevert "[backport] Tweak variance of Ordering.min and .max"f843123Merge pull request #11185 from scala/dependabot/github_actions/2.12.x/actions...dbe2250Bump actions/checkout from 5 to 6d092b1bMerge pull request #11183 from scala-steward/update/2.12.x/commons-lang3-3.20.05b69835Update commons-lang3 to 3.20.0 in 2.12.x597789eMerge pull request #11178 from dragos/dragos/backport-base-type-crash-fix01ad07aMerge pull request #11175 from lrytz/t13127-127dcf3a6Add@uncheckedOverrideannotation for definitions that may overridea70746cPrevent presentation compiler crash on base type cache invalidationMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)